Recent changes to patches

#309 Use --no-insert-timestamp to make builds reproducible

2026-04-25T13:00:39.915000Z

labels: --> reproducible builds
status: open --> closed-out-of-date

#318 add support for windows ARM64 in makensis.nsi

2026-04-09T18:37:20.975000Z

status: open --> closed-fixed

#318 add support for windows ARM64 in makensis.nsi

2026-04-09T14:13:17.074000Z

NSIS_ARM64 is defined to a number >= 1 when compiling for ARM64 (undocumented). Ideally we would be able to install stubs and plugins for multiple architectures so we don't actually want to check that here.

#318 add support for windows ARM64 in makensis.nsi

2026-04-08T03:36:48.328000Z

Yes, you can check it at runtime but not at compile time currently.

!include x64.nsh

${If} ${IsNativeARM64}

${EndIf}

#318 add support for windows ARM64 in makensis.nsi

2026-04-06T09:08:12.204000Z

The better way to do it is like this:

!macro InstallPlugin pi
  !if /FileExists ..\Plugins\amd64-unicode\${pi}.dll
    File "/oname=$InstDir\Plugins\amd64-unicode\${pi}.dll" ..\Plugins\amd64-unicode\${pi}.dll
  !endif
  !if /FileExists ..\Plugins\arm64-unicode\${pi}.dll
    File "/oname=$InstDir\Plugins\arm64-unicode\${pi}.dll" ..\Plugins\arm64-unicode\${pi}.dll
  !endif
  !if /FileExists ..\Plugins\x86-ansi\${pi}.dll
    File "/oname=$InstDir\Plugins\x86-ansi\${pi}.dll" ..\Plugins\x86-ansi\${pi}.dll
  !endif
  !if /FileExists ..\Plugins\x86-unicode\${pi}.dll
    File "/oname=$InstDir\Plugins\x86-unicode\${pi}.dll" ..\Plugins\x86-unicode\${pi}.dll
  !endif
!macroend

!macro InstallStub stub
  !if /FileExists ..\Stubs\${stub}-amd64-unicode
    File ..\Stubs\${stub}-amd64-unicode
  !endif
  !if /FileExists ..\Stubs\${stub}-arm64-unicode
    File ..\Stubs\${stub}-arm64-unicode
  !endif
  !if /FileExists ..\Stubs\${stub}-x86-ansi
    File ..\Stubs\${stub}-x86-ansi
  !endif
  !if /FileExists ..\Stubs\${stub}-x86-unicode
    File ..\Stubs\${stub}-x86-unicode
  !endif
!macroend

The nsi script, as far as I know, doesn't have a way to detect arm64 at compile time. Arm64 support still isn't complete yet. Maybe we could add a predefine to makensis / .nsi script that says what architecture it's targeting?

add support for windows ARM64 in makensis.nsi

2026-04-04T11:48:47.952000Z

I was running test on Windows ARM64, and found that Example/makensis.nsi doesn't have ARM64 support yet.

add support for windows ARM64 in makensis.nsi

2026-04-04T11:48:47.952000Z

Ticket 318 has been modified: add support for windows ARM64 in makensis.nsi
Edited By: Anders (anders_k)
Status updated: 'open' => 'closed-fixed'

#317 ZSTD compression

2026-03-18T09:16:45.678000Z

I'm interested in having NSIS with ZSTD. There was some discussion over on github recently (https://github.com/NSIS-Dev/nsis/pull/28) and I would like to know a few things:

It seems the original PR (https://github.com/NSIS-Dev/nsis/pull/16) was opened 5 years ago but never merged. It was then moved to #28, but no response from you, the maintainers. What is your plan with regard to this PR?
There is some discussion about supporting old targets, which requires importing half the universe for ZSTD to work. What's the goal for NSIS, is there any particular reason to support targeting systems that are over 30 years old?
The same discussion was joined by consumers of NSIS for such old targets and it appears they would be ok with support for those old targets moved to the special build. What's your opinion on that?

as a complete side note, since I haven't seen any discussion about it on your tracker, are there any plans to move to git?

#317 ZSTD compression

2025-02-04T14:04:07.648000Z

SetPEWin95Supported should be called SetPEWinVerSupported since it applies to NT4 as well? It should pass in 4 for x86 stubs and plugins and 5 for AMD64.
_allmul and _allshl should be hidden behind a ZSTD define so they are not used by accident in other places. We would also need the equivalent asm code for GCC?
The Math plug-in can't statically link whatever it needs from the MS CRT?
Ideally the MSVC support should be added in a separate step first.

(Githubs policy is blocking me from logging in on Github so I can't respond there)

ZSTD compression

2025-02-03T20:43:27.542000Z

I have added ZSTD compression to NSIS, please see this PR for details on Github: https://github.com/kichik/nsis/pull/28

It would mean moving away from MSVC6, however I have also added changes that would restore Win9x compatibility on modern MSVC.